refactor: rename browser submodule to _browser to avoid shadowing browser()
This commit is contained in:
@@ -4,7 +4,7 @@ from unittest.mock import MagicMock
|
||||
import pytest
|
||||
from selenium.common.exceptions import WebDriverException
|
||||
|
||||
from wabot.browser import Browser
|
||||
from wabot._browser import Browser
|
||||
from wabot.pacing import HumanPacing, NoPacing
|
||||
from wabot.page import Page
|
||||
|
||||
@@ -124,15 +124,7 @@ class TestQuit:
|
||||
driver.quit.assert_called_once_with()
|
||||
|
||||
def test_quit_stops_managed_service(self, monkeypatch):
|
||||
import sys
|
||||
|
||||
# NOTE(Task 12 wiring fix): `import wabot.browser as browser_mod` would
|
||||
# resolve to `wabot.browser` the FUNCTION (the public API added in
|
||||
# Task 12 shadows the submodule attribute of the same name on the
|
||||
# `wabot` package once `wabot/__init__.py` defines `def browser(...)`).
|
||||
# sys.modules keeps the real submodule reachable regardless of what
|
||||
# the package's own `browser` attribute is rebound to.
|
||||
browser_mod = sys.modules["wabot.browser"]
|
||||
import wabot._browser as browser_mod
|
||||
|
||||
stopped = []
|
||||
monkeypatch.setattr(browser_mod, "stop_service", lambda pid: stopped.append(pid))
|
||||
@@ -144,10 +136,7 @@ class TestQuit:
|
||||
store.remove.assert_called_once_with("s1")
|
||||
|
||||
def test_quit_removes_record_even_if_driver_quit_raises(self, monkeypatch):
|
||||
import sys
|
||||
|
||||
# see NOTE in test_quit_stops_managed_service above
|
||||
browser_mod = sys.modules["wabot.browser"]
|
||||
import wabot._browser as browser_mod
|
||||
|
||||
monkeypatch.setattr(browser_mod, "stop_service", lambda pid: None)
|
||||
driver, store = MagicMock(), MagicMock()
|
||||
|
||||
Reference in New Issue
Block a user