fix: browser()/destroy() never leak a managed driver service

tests/unit/test_api.py

@@ -137,6 +137,92 @@ class TestHousekeeping:
         assert wabot.destroy("nope", store=store) is False
 
 
+class TestResourceCleanup:
+    def test_managed_service_stopped_when_driver_creation_fails(
+        self, fake_selenium, store, monkeypatch
+    ):
+        from selenium.common.exceptions import WebDriverException
+
+        stopped = []
+        monkeypatch.setattr(wabot, "stop_service", lambda pid: stopped.append(pid))
+        fake_selenium.Remote.side_effect = WebDriverException("startup failed")
+        with pytest.raises(WebDriverException):
+            wabot.browser(session="s1", browser="chromium", store=store)
+        assert stopped == [4321]  # spawned managed service was stopped
+        assert store.get("s1") is None  # nothing persisted
+
+    def test_dead_managed_session_stops_old_service_before_recreating(
+        self, fake_selenium, store, monkeypatch
+    ):
+        from datetime import datetime, timezone
+
+        stopped = []
+        monkeypatch.setattr(wabot, "stop_service", lambda pid: stopped.append(pid))
+        store.save(wabot.SessionRecord(
+            name="s1", executor_url="http://127.0.0.1:7777", session_id="old",
+            browser="chromium", created_at=datetime.now(timezone.utc).isoformat(),
+            service_pid=9999, service_port=7777,
+        ))
+        fake_selenium.service_alive.return_value = True
+        fake_selenium.attach.return_value = None  # session dead on a live server
+        wabot.browser(session="s1", store=store)
+        assert 9999 in stopped  # old managed service stopped, not leaked
+        fake_selenium.Remote.assert_called_once()  # fresh browser created
+        assert store.get("s1").session_id == "new-session-id"
+
+
+class TestDestroyEdges:
+    def _save(self, store, **kw):
+        from datetime import datetime, timezone
+
+        defaults = dict(
+            name="s1", executor_url="http://127.0.0.1:7777", session_id="old",
+            browser="chromium", created_at=datetime.now(timezone.utc).isoformat(),
+        )
+        defaults.update(kw)
+        store.save(wabot.SessionRecord(**defaults))
+
+    def test_destroy_external_session_does_not_stop_service(
+        self, fake_selenium, store, monkeypatch
+    ):
+        stopped = []
+        monkeypatch.setattr(wabot, "stop_service", lambda pid: stopped.append(pid))
+        self._save(store, name="ext", executor_url="http://grid:4444", service_pid=None)
+        fake_selenium.service_alive.return_value = True
+        assert wabot.destroy("ext", store=store) is True
+        assert stopped == []  # external server: not ours to stop
+        assert store.get("ext") is None
+
+    def test_destroy_dead_session_still_stops_and_removes(self, fake_selenium, store, monkeypatch):
+        stopped = []
+        monkeypatch.setattr(wabot, "stop_service", lambda pid: stopped.append(pid))
+        self._save(store, service_pid=4321)
+        fake_selenium.service_alive.return_value = True
+        fake_selenium.attach.return_value = None  # dead session
+        assert wabot.destroy("s1", store=store) is True
+        assert stopped == [4321]  # service stopped despite dead session
+        assert store.get("s1") is None
+
+
+class TestPlumbing:
+    def test_headless_and_user_agent_reach_build_options(self, fake_selenium, store, monkeypatch):
+        captured = {}
+        real_build = wabot.build_options
+
+        def spy(browser, **kwargs):
+            captured.update(kwargs)
+            return real_build(browser, **kwargs)
+
+        monkeypatch.setattr(wabot, "build_options", spy)
+        wabot.browser(browser="chromium", headless=True, user_agent="Bot/1.0", store=store)
+        assert captured == {"headless": True, "user_agent": "Bot/1.0"}
+
+    def test_pacing_reaches_browser(self, fake_selenium, store):
+        pacing = wabot.NoPacing()
+        bot = wabot.browser(browser="chromium", pacing=pacing, store=store)
+        assert bot.pacing is pacing
+
+
 class TestPublicSurface:
     def test_all_exports_exist(self):
         for name in wabot.__all__: