feat: add Ask ChatGPT toolbar action

2026-10-12 12:51:24 -06:00
parent 5bc670b937
commit 78e94640e1
8 changed files with 180 additions and 18 deletions
@@ -0,0 +1,60 @@
+# Toolbar action verification — 2026-10-12
+
+The Ask ChatGPT toolbar button uses the existing Ask action: selected text is
+wrapped in the saved prompt; an empty or unreadable selection opens a blank
+chat. Saved opening preferences and shortening consent apply. No new
+permissions, popup, or settings were added.
+
+## Automated checks
+
+- Fresh `npm test` before the PR: strict extension lint reports zero errors,
+  warnings, or notices; all 61 tests across 11 test files pass; ZIP build passes.
+- New toolbar regression covers the clicked tab rather than a later active tab,
+  focused iframe selection with stale parent/sibling selections, empty/unfocused
+  selection, saved prompt/background-tab preferences, and restricted-page
+  fallback with the new-window preference.
+- ZIP inspection excludes docs, tests, and local tool metadata.
+- Independent read-only review found no concrete code defects; the requested
+  browser checks for focus handling and shortening consent were then completed.
+
+## Firefox 157.0.1 checks
+
+Launched with `npm run dev` in temporary headless profiles. Marionette clicked
+Firefox's actual action button; it did not call the extension handler directly.
+
+- Pinned toolbar: top-frame selection reaches the ChatGPT URL; no selection
+  opens `https://chatgpt.com/`.
+- Same-origin and cross-origin iframe selections win over a stale top-frame
+  selection.
+- `about:config` opens a blank chat.
+- Unpinned action in the extensions menu preserves top-frame and cross-origin
+  iframe selections, including a stale parent selection.
+- Changing the prompt through the options UI works with context-menu mode Off.
+- A long selection opens the shortening-consent dialog. Cancel closes it
+  without opening ChatGPT.
+- The pinned icon was visually confirmed in Firefox.
+
+The selection reader retains the shortcut's focused-leaf-frame filter. Actual
+mouse activation through Firefox's toolbar and extensions menu preserved the
+necessary focus in these checks; no broader frame scan was introduced.
+
+The maintainer subsequently confirmed the toolbar button works during desktop
+use. Every editable field type and the full release regression matrix in
+AGENTS.md were not rechecked; existing shortcut-specific manual release checks
+remain outstanding.
+
+## ChatGPT submission limitation
+
+These checks establish that the extension opens the expected URL and preserves
+the selection. They do not guarantee that ChatGPT accepts or automatically
+submits the prompt.
+
+During follow-up testing, URL-supplied prompts showed a ChatGPT verification
+error while signed out on affected machines. Signing in allowed the prompt to
+fill the composer, but it could still require Enter. The verification failure
+also occurred when the URL was entered directly with this extension disabled.
+The cause remains unconfirmed.
+
+The pre-toolbar version and this version generate the same
+`https://chatgpt.com/?q=hello` URL for a default Ask action; the address-bar search
+definition is also unchanged. No forced submission or workaround was added.